Enabled Topic Owners to properly delete posts in their topic #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can delete posts in their topic. modified socket.io/posts/tools.js to not display admin positions along with topic owner position
|
Your PR looks good but your code appears to be failing some of the lint tests. I would recommend making the changes suggested by the linter but otherwise looks good. |
Pull Request Test Coverage Report for Build 13557533598Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
RyanChernoff
approved these changes
Feb 26, 2025
rmurugan58
requested changes
Feb 27, 2025
rmurugan58
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Topic Owners could see the delete option on posts under their topic/thread but upon clicking the delete button, they would not have the permissions to delete and so the action would fail.
Description
Now, when a topic owner selects a post, the post will be marked as deleted and have all the attributes of a deleted post.
File Changes
src/socket.io/posts/tools.js
Updated the display permissions to display admin or moderator post options only if the user is an admin or moderator and not just if they have edit or delete permissions
src/privileges/posts.js
Under the privPosts.canDelete function, added a variable to check if the user is a topic owner and modified the flag to also be true if the user is the topic owner.
test/posts.js
Added set up and test case to see a topic Owner has the permission/privilege to delete posts under their topic.
Testing
Verified changes on the front end. Topic owner was able to successfully delete posts and did not have admin permissions.
Verified back end changes worked properly through test cases in test/posts.js